Add opt to use AZ for APISeverLoadBalancer by nguyenhuukhoi · Pull Request #1979 · kubernetes-sigs/cluster-api-provider-openstack

nguyenhuukhoi · 2024-03-28T06:16:10Z

What this PR does / why we need it: We need this option to use in case of having edge

This PR allows to choose AZ for API Load Balancer. It will be useful if we want to use edge sites,

/ok-to-test

k8s-ci-robot · 2024-03-28T06:16:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nguyenhuukhoi
Once this PR has been reviewed and has the lgtm label, please assign jichenjc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-03-28T06:16:20Z

Hi @nguyenhuukhoi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2024-03-28T06:16:25Z

@nguyenhuukhoi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

What this PR does / why we need it: We need this option to use in case of having edge

This PR allows to choose AZ for API Load Balancer. It will be useful if we want to use edge sites,

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2024-03-28T06:16:27Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`2cb079c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660c9c396d05f20008d6ab7a
😎 Deploy Preview	https://deploy-preview-1979--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

huxcrux · 2024-03-28T11:29:09Z

/ok-to-test

huxcrux

The removal of functions in the conversion seems to break CI. We probably want to fix some kind of migration even if it is loosy?

huxcrux · 2024-03-29T14:59:14Z

api/v1alpha6/zz_generated.conversion.go

-func Convert_v1beta1_APIServerLoadBalancer_To_v1alpha6_APIServerLoadBalancer(in *v1beta1.APIServerLoadBalancer, out *APIServerLoadBalancer, s conversion.Scope) error {
-	return autoConvert_v1beta1_APIServerLoadBalancer_To_v1alpha6_APIServerLoadBalancer(in, out, s)
-}
-


I do not think we want to remove this part since it is expected to exist. If anything fails a change in the migration might be needed

huxcrux · 2024-03-29T15:00:02Z

api/v1alpha7/zz_generated.conversion.go

-// Convert_v1beta1_APIServerLoadBalancer_To_v1alpha7_APIServerLoadBalancer is an autogenerated conversion function.
-func Convert_v1beta1_APIServerLoadBalancer_To_v1alpha7_APIServerLoadBalancer(in *v1beta1.APIServerLoadBalancer, out *APIServerLoadBalancer, s conversion.Scope) error {
-	return autoConvert_v1beta1_APIServerLoadBalancer_To_v1alpha7_APIServerLoadBalancer(in, out, s)
-}
-


Same here we probably do not want to remove this function since it is in use

dulek · 2024-04-02T15:36:59Z

I took the freedom to try to fix this patch, please check out: nguyenhuukhoi#1

nguyenhuukhoi · 2024-04-02T15:45:16Z

Hello. Thank you for your help. I am busy on this week. I will continue next week.

…

On Tue, Apr 2, 2024, 10:37 PM Michal Dulko ***@***.***> wrote: I took the freedom to try to fix this patch, please check out: nguyenhuukhoi#1 <nguyenhuukhoi#1> — Reply to this email directly, view it on GitHub <#1979 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADRLKQO2VFMJQPT27N4YIEDY3LGDDAVCNFSM6AAAAABFMF6VVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGQYDCNRXGM> . You are receiving this because you were mentioned.Message ID: <kubernetes-sigs/cluster-api-provider-openstack/pull/1979/c2032401673@ github.com>

Add opt to use AZ for APISeverLoadBalancer

nguyenhuukhoi · 2024-04-02T23:02:45Z

/retest

nguyenhuukhoi · 2024-04-02T23:47:45Z

I took the freedom to try to fix this patch, please check out: nguyenhuukhoi#1

Hello. I do a mistake. Could you help me revert it?

k8s-ci-robot · 2024-04-03T00:01:04Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2024-04-03T00:01:42Z

@nguyenhuukhoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-openstack-build	`2cb079c`	link	true	`/test pull-cluster-api-provider-openstack-build`
pull-cluster-api-provider-openstack-test	`2cb079c`	link	true	`/test pull-cluster-api-provider-openstack-test`
pull-cluster-api-provider-openstack-e2e-test	`2cb079c`	link	true	`/test pull-cluster-api-provider-openstack-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dulek · 2024-04-05T15:38:13Z

I submitted a new PR where I rebased this: #2004.

mdbooth · 2024-04-09T16:37:59Z

As noted, this commit has been rebased into PR #2004

Add opt to use AZ for APISeverLoadBalancer

c70693c

k8s-ci-robot requested review from dulek and lentzi90 March 28, 2024 06:16

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2024

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2024

huxcrux reviewed Mar 29, 2024

View reviewed changes

Add opt to use AZ for APISeverLoadBalancer

dfbc3ef

Merge pull request #1 from dulek/nguyenhuukhoi/main

2cb079c

Add opt to use AZ for APISeverLoadBalancer

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024

nguyenhuukhoi force-pushed the main branch from 0c575ca to 2cb079c Compare April 3, 2024 00:00

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024

dulek mentioned this pull request Apr 5, 2024

Add opt to use AZ for APISeverLoadBalancer #2004

Merged

3 tasks

mdbooth closed this Apr 9, 2024

Conversation

nguyenhuukhoi commented Mar 28, 2024

Uh oh!

k8s-ci-robot commented Mar 28, 2024

Uh oh!

k8s-ci-robot commented Mar 28, 2024

Uh oh!

k8s-ci-robot commented Mar 28, 2024

Uh oh!

netlify bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Uh oh!

huxcrux commented Mar 28, 2024

Uh oh!

huxcrux left a comment

Choose a reason for hiding this comment

Uh oh!

huxcrux Mar 29, 2024

Choose a reason for hiding this comment

Uh oh!

huxcrux Mar 29, 2024

Choose a reason for hiding this comment

Uh oh!

dulek commented Apr 2, 2024

Uh oh!

nguyenhuukhoi commented Apr 2, 2024 via email

Uh oh!

nguyenhuukhoi commented Apr 2, 2024

Uh oh!

nguyenhuukhoi commented Apr 2, 2024

Uh oh!

k8s-ci-robot commented Apr 3, 2024

Uh oh!

k8s-ci-robot commented Apr 3, 2024

Uh oh!

dulek commented Apr 5, 2024

Uh oh!

mdbooth commented Apr 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify bot commented Mar 28, 2024 •

edited

Loading